Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle aggregatedList case for generated sweepers #1619

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#5300

This PR includes:

  • Removes skip_sweeper flag from resources that use aggregatedList (generates 5 new sweepers)
  • Special case handling within sweeper template for aggregatedList

Edit:
Ran this PR in our CI, you can find the new sweepers running here.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#2941

chrisst and others added 19 commits January 6, 2020 15:51
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Dana Hoffman <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Riley Karson <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Brian Hildebrandt <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: emily <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Riley Karson <[email protected]>
Handle aggregatedList case for generated sweepers
@ghost ghost added the size/xxl label Jan 9, 2020
@modular-magician modular-magician merged commit 30f61f5 into hashicorp:downstream-master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants