-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle aggregatedList case for generated sweepers #1619
Merged
modular-magician
merged 19 commits into
hashicorp:downstream-master
from
modular-magician:downstream-pr-b66fd1d66acbe76821edcbaf8c068455e23a3a96
Jan 9, 2020
Merged
Handle aggregatedList case for generated sweepers #1619
modular-magician
merged 19 commits into
hashicorp:downstream-master
from
modular-magician:downstream-pr-b66fd1d66acbe76821edcbaf8c068455e23a3a96
Jan 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]>
…icorp#1586) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Riley Karson <[email protected]>
…p#1588) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Martin Nowak <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Brian Hildebrandt <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Riley Karson <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
…#1613) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Riley Karson <[email protected]>
…#1615) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
Handle aggregatedList case for generated sweepers
ghost
added
the
size/xxl
label
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hashicorp/terraform-provider-google#5300
This PR includes:
skip_sweeper
flag from resources that use aggregatedList (generates 5 new sweepers)Edit:
Ran this PR in our CI, you can find the new sweepers running here.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#2941