Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made AppEngine requests retry if they fail due to a P4SA propagation delay #2922

Conversation

modular-magician
Copy link
Collaborator

Fixed hashicorp/terraform-provider-google#8333

Example failure: https://ci-oss.hashicorp.engineering/repository/download/GoogleCloudBeta_ProviderGoogleCloudBetaGoogleProject/168545:id/debug-google-beta-6582f9f-TestAccAppEngineFlexibleAppVersion_update.log

App Engine already has a retry predicate, so I expanded it to include the new error as well.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

appengine: added retry for P4SA propagation delay

Derived from GoogleCloudPlatform/magic-modules#4453

@ghost ghost added size/xs labels Feb 2, 2021
@modular-magician modular-magician merged commit a0b3dc6 into hashicorp:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant