Fixes terraform-provider-google#13266 Add Firebase label for all examples that creates a new Firebase Project #5122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#13266
When
google_firebase_project
is used, it adds a labelfirebase:enabled
to the underlying GCP project. This label will be accidentally deleted when runningterraform apply
again because the label isn't present in thegoogle_project
resource block. This has caused Firebase projects created in Terraform to not show in the Firebase Console and Firebase CLI.While we can't 100% prevent users from deleting the label, at least the examples should be correct.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7149