Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new region instance template resource #5370

Conversation

modular-magician
Copy link
Collaborator

Background
Regional Instance Template (later: RIT) is a new regional resource, implementing the functionality of Instance Templates existing before only in the global scope. More details can be found: go/rit-support-in-terraform.

There is already a handwritten global scope google_compute_instance_template Terraform resource and as we implement the new RIT resource, we want to give customers a smooth migration experience from GIT to RIT, the decision is to hand write RIT as GIT to keep the resource representation consistent. More info can be found: go/rit-resource-inconsistency

Changes include:

Add Region Instance Template resource, acceptance tests and document.
Modify existing google_compute_instance_from_template resource to consume RIT as source instance template.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_instance_template`
compute: supported region instance template in`source_instance_template` field of `google_compute_instance_from_template` resource

Derived from GoogleCloudPlatform/magic-modules#7507

Co-authored-by: Jingcong Wang <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 324bd41 into hashicorp:main Mar 27, 2023
rileykarson added a commit to rileykarson/terraform-provider-google-beta that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant