alloydb: re-enabled VCR for TestAccAlloydb* tests
#8606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:05cac2e2ab98a4cd96aa650d4c4442e25ac656b7] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#16231
From this comment, I think these 3 tests can just be re-enabled, unless there's something else specific the owning team has to do?
All 3 of these pass in both recording and replaying mode in my test project, though IIRC, I got a segfault vs. just an error before enabling
servicenetworking(is there a utility to ensure a specific service is enabled in the default test project). I think you have a way to run this in Teamcity too, which would probably confirm if the test will work there?Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12227