Add SHA and etag to AndroidApp and update package_name (#7066) (#13444)

Signed-off-by: Modular Magician <[email protected]> Signed-off-by: Modular Magician <[email protected]>
hashicorp · Jan 10, 2023 · 4f327dd · 4f327dd
1 parent 9bd90d9
commit 4f327dd
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 6 deletions.
diff --git a/.changelog/7066.txt b/.changelog/7066.txt
@@ -0,0 +1,6 @@
+```release-note:enhancement
+android_app: Added general fields `sha1_hashes`, `sha256_hashes` and `etag` to `google_firebase_android_app`.
+```
+```release-note:bug
+android_app: Modify the `package_name` field suffix to always start with a letter in `google_firebase_android_app`.
+```
diff --git a/website/docs/d/firebase_android_app.html.markdown b/website/docs/d/firebase_android_app.html.markdown
@@ -37,15 +37,25 @@ In addition to the arguments listed above, the following computed attributes are
 * `id` - an identifier for the resource with format `{{name}}`
 
 * `name` -
-  The fully qualified resource name of the App, for example:
+  The fully qualified resource name of the AndroidApp, for example:
   projects/projectId/androidApps/appId
 
 * `app_id` -
-  Immutable. The globally unique, Firebase-assigned identifier of the App.
+  Immutable. The globally unique, Firebase-assigned identifier of the AndroidApp.
   This identifier should be treated as an opaque token, as the data format is not specified.
 
 * `display_name` -
-  The user-assigned display name of the App.
+  The user-assigned display name of the AndroidApp.
 
 * `package_name` -
   The canonical package name of the Android app as would appear in the Google Play Developer Console.
+
+* `sha1_hashes` -
+  The SHA1 certificate hashes for the AndroidApp.
+
+* `sha256_hashes` -
+  The SHA256 certificate hashes for the AndroidApp.
+
+* `etag` -
+  This checksum is computed by the server based on the value of other fields, and it may be sent
+  with update requests to ensure the client has an up-to-date value before proceeding.
diff --git a/website/docs/r/firebase_android_app.html.markdown b/website/docs/r/firebase_android_app.html.markdown
@@ -40,6 +40,8 @@ resource "google_firebase_android_app" "basic" {
   project = "my-project-name"
   display_name = "Display Name Basic"
   package_name = ""
+  sha1_hashes = ["2145bdf698b8715039bd0e83f2069bed435ac21c"]
+  sha256_hashes = ["2145bdf698b8715039bd0e83f2069bed435ac21ca1b2c3d4e5f6123456789abc"]
 }
 ```
 
@@ -50,7 +52,7 @@ The following arguments are supported:
 
 * `display_name` -
   (Required)
-  The user-assigned display name of the App.
+  The user-assigned display name of the AndroidApp.
 
 
 - - -
@@ -61,6 +63,14 @@ The following arguments are supported:
   Immutable. The canonical package name of the Android app as would appear in the Google Play
   Developer Console.
 
+* `sha1_hashes` -
+  (Optional)
+  The SHA1 certificate hashes for the AndroidApp.
+
+* `sha256_hashes` -
+  (Optional)
+  The SHA256 certificate hashes for the AndroidApp.
+
 * `deletion_policy` -
   (Optional)
   (Optional) Set to `ABANDON` to allow the AndroidApp to be untracked from terraform state
@@ -78,13 +88,17 @@ In addition to the arguments listed above, the following computed attributes are
 * `id` - an identifier for the resource with format `{{name}}`
 
 * `name` -
-  The fully qualified resource name of the App, for example:
+  The fully qualified resource name of the AndroidApp, for example:
   projects/projectId/androidApps/appId
 
 * `app_id` -
-  The globally unique, Firebase-assigned identifier of the App.
+  The globally unique, Firebase-assigned identifier of the AndroidApp.
   This identifier should be treated as an opaque token, as the data format is not specified.
 
+* `etag` -
+  This checksum is computed by the server based on the value of other fields, and it may be sent
+  with update requests to ensure the client has an up-to-date value before proceeding.
+
 
 ## Timeouts