fixing id for a data source (#6476) (#12405)

Co-authored-by: Edward Sun <[email protected]> Signed-off-by: Modular Magician <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Edward Sun <[email protected]>
hashicorp · Aug 26, 2022 · 7d8357c · 7d8357c
1 parent 48dbb51
commit 7d8357c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/6476.txt b/.changelog/6476.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed the `id` format of the data source `google_compute_instance`
+```
diff --git a/google/data_source_google_compute_instance.go b/google/data_source_google_compute_instance.go
@@ -191,6 +191,6 @@ func dataSourceGoogleComputeInstanceRead(d *schema.ResourceData, meta interface{
 	if err := d.Set("name", instance.Name); err != nil {
 		return fmt.Errorf("Error setting name: %s", err)
 	}
-	d.SetId(fmt.Sprintf("projects/%s/zones/%s/instances/%s", project, instance.Zone, instance.Name))
+	d.SetId(fmt.Sprintf("projects/%s/zones/%s/instances/%s", project, GetResourceNameFromSelfLink(instance.Zone), instance.Name))
 	return nil
 }