fix google_client_config (#7953) (#14618)

Signed-off-by: Modular Magician <[email protected]>
hashicorp · May 16, 2023 · 7dd0a58 · 7dd0a58
1 parent 3892009
commit 7dd0a58
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/.changelog/7953.txt b/.changelog/7953.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+provider: fixed an issue where `google_client_config` datasource return `null` for all attributes when region or zone is unset in provider config
+```
diff --git a/google/data_source_google_client_config.go b/google/data_source_google_client_config.go
@@ -124,16 +124,8 @@ func (d *GoogleClientConfigDataSource) Read(ctx context.Context, req datasource.
 	}
 
 	locationInfo := data.GetLocationDescription(d.providerConfig)
-	region, err := locationInfo.GetRegion()
-	if err != nil {
-		diags.AddError("Error getting region value", err.Error())
-		return
-	}
-	zone, err := locationInfo.GetZone()
-	if err != nil {
-		diags.AddError("Error getting zone value", err.Error())
-		return
-	}
+	region, _ := locationInfo.GetRegion()
+	zone, _ := locationInfo.GetZone()
 
 	data.Id = types.StringValue(fmt.Sprintf("projects/%s/regions/%s/zones/%s", d.providerConfig.project.String(), region.String(), zone.String()))
 	data.Project = d.providerConfig.project