Skip to content

Commit

Permalink
Remove stray beta clients in GA (#5379) (#10456)
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Oct 29, 2021
1 parent 6a9ff13 commit fb557be
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 58 deletions.
2 changes: 2 additions & 0 deletions .changelog/5379.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
```release-note:none
```
5 changes: 2 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ require (
github.com/zclconf/go-cty v1.5.1 // indirect
golang.org/x/mod v0.5.0 // indirect
golang.org/x/net v0.0.0-20210503060351-7fd8e65b6420
golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f
golang.org/x/sys v0.0.0-20210915083310-ed5796bab164 // indirect
google.golang.org/api v0.56.0
golang.org/x/oauth2 v0.0.0-20211005180243-6b3c2da341f1
google.golang.org/api v0.59.0
google.golang.org/grpc v1.40.0
)

Expand Down
58 changes: 22 additions & 36 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion google/composer_operation.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"fmt"
"time"

composer "google.golang.org/api/composer/v1beta1"
"google.golang.org/api/composer/v1"
)

type ComposerOperationWaiter struct {
Expand Down
5 changes: 1 addition & 4 deletions google/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"google.golang.org/api/cloudkms/v1"
"google.golang.org/api/cloudresourcemanager/v1"
resourceManagerV2 "google.golang.org/api/cloudresourcemanager/v2"
composer "google.golang.org/api/composer/v1beta1"
"google.golang.org/api/composer/v1"
"google.golang.org/api/compute/v1"
"google.golang.org/api/container/v1"
dataflow "google.golang.org/api/dataflow/v1b3"
Expand Down Expand Up @@ -147,7 +147,6 @@ type Config struct {
CloudBillingBasePath string
ComposerBasePath string
ContainerBasePath string
DataprocBetaBasePath string
DataflowBasePath string
IamCredentialsBasePath string
ResourceManagerV2BasePath string
Expand Down Expand Up @@ -237,7 +236,6 @@ const WorkflowsBasePathKey = "Workflows"
const CloudBillingBasePathKey = "CloudBilling"
const ComposerBasePathKey = "Composer"
const ContainerBasePathKey = "Container"
const DataprocBetaBasePathKey = "DataprocBeta"
const DataflowBasePathKey = "Dataflow"
const IAMBasePathKey = "IAM"
const IamCredentialsBasePathKey = "IamCredentials"
Expand Down Expand Up @@ -317,7 +315,6 @@ var DefaultBasePaths = map[string]string{
CloudBillingBasePathKey: "https://cloudbilling.googleapis.com/v1/",
ComposerBasePathKey: "https://composer.googleapis.com/v1/",
ContainerBasePathKey: "https://container.googleapis.com/v1/",
DataprocBetaBasePathKey: "https://dataproc.googleapis.com/v1beta2/",
DataflowBasePathKey: "https://dataflow.googleapis.com/v1b3/",
IAMBasePathKey: "https://iam.googleapis.com/v1/",
IamCredentialsBasePathKey: "https://iamcredentials.googleapis.com/v1/",
Expand Down
3 changes: 0 additions & 3 deletions google/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,6 @@ func Provider() *schema.Provider {
CloudBillingCustomEndpointEntryKey: CloudBillingCustomEndpointEntry,
ComposerCustomEndpointEntryKey: ComposerCustomEndpointEntry,
ContainerCustomEndpointEntryKey: ContainerCustomEndpointEntry,
DataprocBetaCustomEndpointEntryKey: DataprocBetaCustomEndpointEntry,
DataflowCustomEndpointEntryKey: DataflowCustomEndpointEntry,
IamCredentialsCustomEndpointEntryKey: IamCredentialsCustomEndpointEntry,
ResourceManagerV2CustomEndpointEntryKey: ResourceManagerV2CustomEndpointEntry,
Expand Down Expand Up @@ -1413,11 +1412,9 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData, p *schema.Pr
config.WorkflowsBasePath = d.Get("workflows_custom_endpoint").(string)

// Handwritten Products / Versioned / Atypical Entries

config.CloudBillingBasePath = d.Get(CloudBillingCustomEndpointEntryKey).(string)
config.ComposerBasePath = d.Get(ComposerCustomEndpointEntryKey).(string)
config.ContainerBasePath = d.Get(ContainerCustomEndpointEntryKey).(string)
config.DataprocBetaBasePath = d.Get(DataprocBetaCustomEndpointEntryKey).(string)
config.DataflowBasePath = d.Get(DataflowCustomEndpointEntryKey).(string)
config.IamCredentialsBasePath = d.Get(IamCredentialsCustomEndpointEntryKey).(string)
config.ResourceManagerV2BasePath = d.Get(ResourceManagerV2CustomEndpointEntryKey).(string)
Expand Down
10 changes: 0 additions & 10 deletions google/provider_handwritten_endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,6 @@ var ContainerCustomEndpointEntry = &schema.Schema{
}, DefaultBasePaths[ContainerBasePathKey]),
}

var DataprocBetaCustomEndpointEntryKey = "dataproc_beta_custom_endpoint"
var DataprocBetaCustomEndpointEntry = &schema.Schema{
Type: schema.TypeString,
Optional: true,
ValidateFunc: validateCustomEndpoint,
DefaultFunc: schema.MultiEnvDefaultFunc([]string{
"GOOGLE_DATAPROC_BETA_CUSTOM_ENDPOINT",
}, DefaultBasePaths[DataprocBetaBasePathKey]),
}

var DataflowCustomEndpointEntryKey = "dataflow_custom_endpoint"
var DataflowCustomEndpointEntry = &schema.Schema{
Type: schema.TypeString,
Expand Down
3 changes: 2 additions & 1 deletion google/resource_composer_environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import (
"github.com/hashicorp/go-version"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
composer "google.golang.org/api/composer/v1beta1"

"google.golang.org/api/composer/v1"
)

const (
Expand Down

0 comments on commit fb557be

Please sign in to comment.