Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shielded instance configuration in google_dataproc_workflow_template #10565

Closed
fulups opened this issue Nov 16, 2021 · 3 comments
Labels
enhancement priority/1 size/s tpgtools Issues related to the tpgtools generator

Comments

@fulups
Copy link

fulups commented Nov 16, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add support for shielded instance configuration in google_dataproc_workflow_template.
Currently a configuration is available for the gce cluster (see gce_cluster_config) but
it doesn't support shielded_instance_config (see source code).

This support is already implemented in google_dataproc_cluster (see gce_cluster_config/shielded_instance_config):

cluster_config{
  ....
  gce_cluster_config{
    shielded_instance_config{
      enable_secure_boot = true
      enable_vtpm = true
      enable_integrity_monitoring = true
    }
  }
}

New or Affected Resource(s)

  • google_XXXXX

Potential Terraform Configuration

Same format as the configuration available for google_dataproc_cluster

resource "google_dataproc_workflow_template" "template" {
  ....
  placement {
    managed_cluster {
      cluster_name = "my-cluster"
      config {
        gce_cluster_config {
          ....
          shielded_instance_config{
            enable_secure_boot = true
            enable_vtpm = true
            enable_integrity_monitoring = true
         }
       }
  }
}

References

@rileykarson rileykarson added size/s tpgtools Issues related to the tpgtools generator labels Nov 29, 2021
@rileykarson rileykarson added this to the Goals milestone Nov 29, 2021
@megan07 megan07 removed this from the Goals milestone Jul 25, 2022
@rileykarson rileykarson added this to the Sprint 16 (2022) milestone Jul 25, 2022
@t-indumathy
Copy link
Contributor

I have started working on this.

t-indumathy added a commit to t-indumathy/magic-modules that referenced this issue Aug 30, 2022
slevenick pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Sep 1, 2022
#6481)

* Changes to add Shielded VMs support in google_dataproc_workflow_template resource and would also address : hashicorp/terraform-provider-google/issues/10565

* Added new shielded vm test case to vcr test

* updated `go` dependencies and separated the test cases

* reverted all dependencies other than dcl

* removed enterprise-certificate-proxy dependency

* reverted extra dependencies other than dcl
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Sep 1, 2022
hashicorp#6481)

* Changes to add Shielded VMs support in google_dataproc_workflow_template resource and would also address : hashicorp/terraform-provider-google/issues/10565

* Added new shielded vm test case to vcr test

* updated `go` dependencies and separated the test cases

* reverted all dependencies other than dcl

* removed enterprise-certificate-proxy dependency

* reverted extra dependencies other than dcl

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Sep 1, 2022
#6481) (#4647)

* Changes to add Shielded VMs support in google_dataproc_workflow_template resource and would also address : hashicorp/terraform-provider-google/issues/10565

* Added new shielded vm test case to vcr test

* updated `go` dependencies and separated the test cases

* reverted all dependencies other than dcl

* removed enterprise-certificate-proxy dependency

* reverted extra dependencies other than dcl

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Sep 1, 2022
hashicorp#6481)

* Changes to add Shielded VMs support in google_dataproc_workflow_template resource and would also address : hashicorp/issues/10565

* Added new shielded vm test case to vcr test

* updated `go` dependencies and separated the test cases

* reverted all dependencies other than dcl

* removed enterprise-certificate-proxy dependency

* reverted extra dependencies other than dcl

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Sep 1, 2022
#6481) (#12451)

* Changes to add Shielded VMs support in google_dataproc_workflow_template resource and would also address : /issues/10565

* Added new shielded vm test case to vcr test

* updated `go` dependencies and separated the test cases

* reverted all dependencies other than dcl

* removed enterprise-certificate-proxy dependency

* reverted extra dependencies other than dcl

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
renescheepers pushed a commit to renescheepers/magic-modules that referenced this issue Sep 7, 2022
GoogleCloudPlatform#6481)

* Changes to add Shielded VMs support in google_dataproc_workflow_template resource and would also address : hashicorp/terraform-provider-google/issues/10565

* Added new shielded vm test case to vcr test

* updated `go` dependencies and separated the test cases

* reverted all dependencies other than dcl

* removed enterprise-certificate-proxy dependency

* reverted extra dependencies other than dcl
@SarahFrench
Copy link
Member

This issue was addressed in PR #6481 above, and the feature was released in v4.36.0 - see docs here

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement priority/1 size/s tpgtools Issues related to the tpgtools generator
Projects
None yet
Development

No branches or pull requests

6 participants