Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying accelerators in cluster node_config #1067

Closed
kmontag opened this issue Feb 9, 2018 · 5 comments · Fixed by #1115
Closed

Allow specifying accelerators in cluster node_config #1067

kmontag opened this issue Feb 9, 2018 · 5 comments · Fixed by #1115

Comments

@kmontag
Copy link

kmontag commented Feb 9, 2018

Beta support for GPUs on Kubernetes clusters has been released: https://cloud.google.com/kubernetes-engine/docs/concepts/gpus

It looks like they can be added via REST API using the accelerators field in a node pool configuration, e.g. (when creating a cluster):

POST https://container.googleapis.com/v1/projects/foo/zones/us-west1-a/clusters
{
  "cluster": {
    "name": "gpu-test",
    "zone": "us-west1-a",
    "nodePools": [
      {
        "name": "default-pool",
        "initialNodeCount": 1,
        "config": {
          // ...
          "accelerators": [
            {
              "acceleratorCount": 1,
              "acceleratorType": "nvidia-tesla-k80"
            }
          ]
        },
        // ...
      }
    ],
    // ...
  }
}

Would be great if this could be supported in the node_config block for google_container_cluster / google_container_node_pool.

Thanks!

Terraform Version

Run terraform -v to show the version. If you are not running the latest version of Terraform, please upgrade because your issue may have already been fixed.

Terraform v0.11.3
+ provider.google v1.5.0

Affected Resource(s)

  • google_container_cluster
  • google_container_node_pool
@dhague
Copy link
Contributor

dhague commented Feb 14, 2018

I have the same requirement - currently hacking on the code for it, unless someone else has already started work on this?

@nat-henderson
Copy link
Contributor

That's great! Tag me in the PR and I'll expedite the review.

dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 15, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 15, 2018
@dhague
Copy link
Contributor

dhague commented Feb 16, 2018

Almost done with this - in case anyone is desperate for it, the code here works, I just need to tweak the tests to pass (so caveat emptor!). I'm on vacation for a long weekend, so I expect to finish this on Tuesday.

@thomasjungblut
Copy link

I can also pick this up if there's anything urgent, synced with Darren yesterday on what's missing.

dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 21, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 21, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 21, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 21, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 22, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 23, 2018
dhague added a commit to dhague/terraform-provider-google that referenced this issue Feb 23, 2018
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Sep 27, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants