Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: google_access_context_manager_service_perimeter_ingress_policy and google_access_context_manager_service_perimeter_egress_policy resources #12927

Closed
wmuizelaar opened this issue Nov 2, 2022 · 7 comments

Comments

@wmuizelaar
Copy link

wmuizelaar commented Nov 2, 2022

Affected Resource(s)

  • google_access_context_manager_service_perimeter_ingress_policy
  • google_access_context_manager_service_perimeter_egress_policy

Hi,

I filed GoogleCloudPlatform/k8s-config-connector#727 to add more granular support for dealing with VPC SC resources. This includes separate resources for ingress policies and egress policies, following the same pattern as the current google_access_context_manager_service_perimeter_resource resource in the Terraform provider.

Could these seperate resources be implemented?

For google_access_context_manager_serivce_perimeter_ingress_policy, the schema would be the same as the existing ingress_policies block in the perimeter-resource, and for the google_access_context_manager_service_perimeter_egress_policy the schema would be the same as the egress_policies block.

References

  • b/258778964
@AlfatahB
Copy link
Contributor

google_access_context_manager_service_perimeter has ingress_policies and egress_policies fields. I was able to find gcloud commands for setting/updating ingress and egress policies for a service perimeter during creation/updation of that particular service parameter. But, I was unable to find gCloud command or an API doc for configuring ingress and egress policies separately.

@rileykarson
Copy link
Collaborator

rileykarson commented May 4, 2023

Note: While initial revisions were submitted in GoogleCloudPlatform/magic-modules#7762 and GoogleCloudPlatform/magic-modules#7765 and released, they didn't work as intended (as reported by #14425) and are planned to be reworked substantially.

@github-actions github-actions bot added service/accesscontextmanager forward/review In review; remove label to forward labels Aug 17, 2023
@roaks3
Copy link
Collaborator

roaks3 commented Aug 18, 2023

@melinath per your comment on b/258778964, should we forward a new issue to the service team?

@melinath
Copy link
Collaborator

@roaks3 I think we are still holding this issue - attn @c2thorn @hao-nan-li to confirm.

@hao-nan-li
Copy link
Collaborator

This feature should've been completed. GoogleCloudPlatform/magic-modules#8038

@melinath
Copy link
Collaborator

cool, closing as completed in that case.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants