Add ACM policies fine grained resources #8038

hao-nan-li · 2023-05-30T17:43:29Z

Initial commit for ACM policies fine grained resources

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_access_context_manager_service_perimeter_egress_policy`
`google_access_context_manager_service_perimeter_ingress_policy`

modular-magician · 2023-05-30T18:05:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2875 insertions(+), 544 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2979 insertions(+), 648 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_policy.egress_to.external_resources, egress_policy.egress_to.operations.method_selectors.method, egress_policy.egress_to.operations.method_selectors.permission, egress_policy.egress_to.operations.service_name, egress_policy.egress_to.resources, egress_policy.egress_from.identity_type, egress_policy.egress_from.identities

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: ingress_policy.ingress_from.identities, ingress_policy.ingress_from.identity_type, ingress_policy.ingress_from.sources.access_level, ingress_policy.ingress_from.sources.resource, ingress_policy.ingress_to.operations.service_name, ingress_policy.ingress_to.operations.method_selectors.method, ingress_policy.ingress_to.operations.method_selectors.permission, ingress_policy.ingress_to.resources, perimeter

Please add acceptance tests which include these fields.

modular-magician · 2023-05-30T18:08:04Z

Tests analytics

Total tests: 12
Passed tests 12
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-05-30T22:51:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2897 insertions(+), 556 deletions(-))
Terraform Beta: Diff ( 10 files changed, 3001 insertions(+), 660 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_policy.egress_to.external_resources, egress_policy.egress_to.operations.method_selectors.method, egress_policy.egress_to.operations.method_selectors.permission, egress_policy.egress_to.operations.service_name, egress_policy.egress_to.resources, egress_policy.egress_from.identities, egress_policy.egress_from.identity_type

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: ingress_policy.ingress_to.resources, ingress_policy.ingress_to.operations.method_selectors.method, ingress_policy.ingress_to.operations.method_selectors.permission, ingress_policy.ingress_to.operations.service_name, ingress_policy.ingress_from.identities, ingress_policy.ingress_from.identity_type, ingress_policy.ingress_from.sources.access_level, ingress_policy.ingress_from.sources.resource, perimeter

Please add acceptance tests which include these fields.

modular-magician · 2023-05-30T22:54:22Z

Tests analytics

Total tests: 12
Passed tests 12
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-05-30T23:41:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2897 insertions(+), 557 deletions(-))
Terraform Beta: Diff ( 10 files changed, 3001 insertions(+), 661 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_policy.egress_to.external_resources, egress_policy.egress_to.operations.method_selectors.permission, egress_policy.egress_to.operations.method_selectors.method, egress_policy.egress_to.operations.service_name, egress_policy.egress_to.resources, egress_policy.egress_from.identities, egress_policy.egress_from.identity_type

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: ingress_policy.ingress_from.sources.access_level, ingress_policy.ingress_from.sources.resource, ingress_policy.ingress_from.identities, ingress_policy.ingress_from.identity_type, ingress_policy.ingress_to.operations.method_selectors.method, ingress_policy.ingress_to.operations.method_selectors.permission, ingress_policy.ingress_to.operations.service_name, ingress_policy.ingress_to.resources, perimeter

Please add acceptance tests which include these fields.

modular-magician · 2023-05-31T00:36:13Z

Tests analytics

Total tests: 2754
Passed tests 2462
Skipped tests: 283
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccComputeFirewallPolicyRule_multipleRules|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-31T00:48:58Z

Tests passed during RECORDING mode:
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li · 2023-05-31T21:56:29Z

If we make 2 google_access_context_manager_service_perimeter_ingress_policy to represent the ingress_policies as in the tests, we end up with the following error: https://paste.googleplex.com/4661457890312192.

The perimeter will not be patched by the second google_access_context_manager_service_perimeter_ingress_policy

...rty/terraform/tests/resource_access_context_manager_service_perimeter_ingress_policy_test.go

modular-magician · 2023-06-01T18:22:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2900 insertions(+), 558 deletions(-))
Terraform Beta: Diff ( 10 files changed, 3004 insertions(+), 662 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_policy.egress_from.identity_type, egress_policy.egress_from.identities, egress_policy.egress_to.operations.service_name, egress_policy.egress_to.operations.method_selectors.permission, egress_policy.egress_to.operations.method_selectors.method, egress_policy.egress_to.resources, egress_policy.egress_to.external_resources

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: perimeter, ingress_policy.ingress_from.identities, ingress_policy.ingress_from.identity_type, ingress_policy.ingress_from.sources.access_level, ingress_policy.ingress_from.sources.resource, ingress_policy.ingress_to.operations.method_selectors.method, ingress_policy.ingress_to.operations.method_selectors.permission, ingress_policy.ingress_to.operations.service_name, ingress_policy.ingress_to.resources

Please add acceptance tests which include these fields.

modular-magician · 2023-06-01T19:18:01Z

Tests analytics

Total tests: 2759
Passed tests 2463
Skipped tests: 284
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-06-01T19:42:08Z

Tests passed during RECORDING mode:
TestAccSqlUser_postgresAbandon[Debug log]
TestAccSqlUser_postgres[Debug log]
TestAccSqlUser_postgresIAM[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-06-02T18:28:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2860 insertions(+), 559 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2964 insertions(+), 663 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_policy.egress_from.identities, egress_policy.egress_from.identity_type, egress_policy.egress_to.external_resources, egress_policy.egress_to.operations.method_selectors.method, egress_policy.egress_to.operations.method_selectors.permission, egress_policy.egress_to.operations.service_name, egress_policy.egress_to.resources

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: perimeter, ingress_from.identities, ingress_from.identity_type, ingress_from.sources.access_level, ingress_from.sources.resource, ingress_to.resources, ingress_to.operations.method_selectors.method, ingress_to.operations.method_selectors.permission, ingress_to.operations.service_name

Please add acceptance tests which include these fields.

modular-magician · 2023-06-02T19:23:26Z

Tests analytics

Total tests: 2767
Passed tests 2476
Skipped tests: 284
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-06-02T19:36:51Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

hao-nan-li · 2023-06-02T19:47:20Z

egress.log
ingress.log

modular-magician · 2023-06-02T20:04:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2874 insertions(+), 560 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2978 insertions(+), 664 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_from.identities, egress_from.identity_type, egress_to.operations.service_name, egress_to.operations.method_selectors.method, egress_to.operations.method_selectors.permission, egress_to.resources, egress_to.external_resources

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: perimeter, ingress_from.identities, ingress_from.identity_type, ingress_from.sources.resource, ingress_from.sources.access_level, ingress_to.resources, ingress_to.operations.method_selectors.permission, ingress_to.operations.method_selectors.method, ingress_to.operations.service_name

Please add acceptance tests which include these fields.

modular-magician · 2023-06-02T20:58:14Z

Tests analytics

Total tests: 2767
Passed tests 2477
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

modular-magician · 2023-06-02T21:11:31Z

Tests passed during RECORDING mode:
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn

Can we also add a warning to the top of the old egress/ingress policy resources that these resources are deprecated and points to the new ones?

c2thorn · 2023-06-05T17:32:02Z

mmv1/products/accesscontextmanager/ServicePerimeterEgressPolicy.yaml

+  or query against a BigQuery dataset).
+autogen_async: true
+exclude_validator: true
+# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter/IngressPolicy


Suggested change

# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter/IngressPolicy

# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter

c2thorn · 2023-06-05T17:33:01Z

mmv1/products/accesscontextmanager/ServicePerimeterIngressPolicy.yaml

+  or actions they match using the ingressTo field.
+autogen_async: true
+exclude_validator: true
+# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter/IngressPolicy


Suggested change

# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter/IngressPolicy

# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter

c2thorn · 2023-06-05T17:54:20Z

mmv1/products/accesscontextmanager/ServicePerimeterEgressPolicy.yaml

+          perimeter. If left unspecified, then members of `identities` field will
+          be allowed access.
+        values:
+          - :IDENTITY_TYPE_UNSPECIFIED


Suggested change

- :IDENTITY_TYPE_UNSPECIFIED

this had a default value of ANY_IDENTITY right?

c2thorn · 2023-06-05T17:54:26Z

mmv1/products/accesscontextmanager/ServicePerimeterIngressPolicy.yaml

+          perimeter. If left unspecified, then members of `identities` field will be
+          allowed access.
+        values:
+          - :IDENTITY_TYPE_UNSPECIFIED


Suggested change

- :IDENTITY_TYPE_UNSPECIFIED

this had a default value of ANY_IDENTITY right?

hao-nan-li · 2023-06-05T18:31:19Z

Looks like there are couple lint problems, I fixed those that are related to this PR.

modular-magician · 2023-06-05T18:39:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2874 insertions(+), 560 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2978 insertions(+), 664 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_from.identity_type, egress_from.identities, egress_to.operations.service_name, egress_to.operations.method_selectors.method, egress_to.operations.method_selectors.permission, egress_to.resources, egress_to.external_resources

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: perimeter, ingress_from.sources.access_level, ingress_from.sources.resource, ingress_from.identities, ingress_from.identity_type, ingress_to.operations.method_selectors.method, ingress_to.operations.method_selectors.permission, ingress_to.operations.service_name, ingress_to.resources

Please add acceptance tests which include these fields.

modular-magician · 2023-06-05T19:34:50Z

Tests analytics

Total tests: 2768
Passed tests 2479
Skipped tests: 283
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringNotificationChannel_updateSensitiveLabels|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

c2thorn · 2023-06-05T19:35:12Z

mmv1/products/accesscontextmanager/EgressPolicy.yaml

@@ -11,6 +11,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.

+# This resource has been deprecated, please refer to ServicePerimeterEgressPolicy.


Apologies, I should have been more specific. I think we should replace the description of these resources with a warning that it has been deprecated, and tell the user to go to the google_access_context_manager_service_perimeter_*_policy equivalent. My intention is that the registry documentation gets changed so that any users wanting to lookup the ingress/egress policy TF documentation get redirected to the correct ones.

Actually, better yet, let's skip the docs entirely for these resources. Using skip_docs: true

Looks like skip_docs is an attribute for skipping the examples. Do we have another attribute for skipping docs entirely? Otherwise I can change in the description.

Ah, I confused that one then. It looks like we do not have an attribute. Changing the description is fine.

Cool, updated

modular-magician · 2023-06-05T19:47:50Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccMonitoringNotificationChannel_updateSensitiveLabels[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-06-05T21:55:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 2878 insertions(+), 577 deletions(-))
Terraform Beta: Diff ( 12 files changed, 2982 insertions(+), 681 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Untested fields: perimeter, egress_from.identities, egress_from.identity_type, egress_to.external_resources, egress_to.operations.service_name, egress_to.operations.method_selectors.method, egress_to.operations.method_selectors.permission, egress_to.resources

Please add acceptance tests which include these fields.
Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Untested fields: perimeter, ingress_from.identities, ingress_from.identity_type, ingress_from.sources.resource, ingress_from.sources.access_level, ingress_to.operations.method_selectors.method, ingress_to.operations.method_selectors.permission, ingress_to.operations.service_name, ingress_to.resources

Please add acceptance tests which include these fields.

c2thorn

LGTM pending final tests.

modular-magician · 2023-06-05T22:50:07Z

Tests analytics

Total tests: 2770
Passed tests 2480
Skipped tests: 285
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-06-05T23:03:49Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

* Initial commit for ACM policies fine grained resources * Delete old test files * Fix tests failures * Fix tests * Make ingress_policy an array * Change the top level field to be ingressFrom and ingressTo * Support creation for multiple ingress/egress policies * Remove Wrong values in ingress_from/egress_from fields * Fix Lint * Change description for deprecated resources

hao-nan-li added 2 commits May 30, 2023 10:42

Initial commit for ACM policies fine grained resources

c9b9c56

Delete old test files

4ac178a

hao-nan-li mentioned this pull request May 30, 2023

Add Fine Grained Resources acm_service_perimeter_ingress_policy and egress_policy #7861

Closed

5 tasks

Fix tests failures

1f0c8d4

Fix tests

1d9d0ae

hao-nan-li requested a review from c2thorn May 31, 2023 21:53

c2thorn requested changes Jun 1, 2023

View reviewed changes

...rty/terraform/tests/resource_access_context_manager_service_perimeter_ingress_policy_test.go Show resolved Hide resolved

Make ingress_policy an array

1821afb

Change the top level field to be ingressFrom and ingressTo

aeffb2c

Support creation for multiple ingress/egress policies

872fc0e

hao-nan-li marked this pull request as ready for review June 2, 2023 19:45

hao-nan-li changed the title ~~Initial commit for ACM policies fine grained resources~~ Add ACM policies fine grained resources Jun 5, 2023

hao-nan-li requested a review from c2thorn June 5, 2023 17:11

c2thorn requested changes Jun 5, 2023

View reviewed changes

hao-nan-li added 2 commits June 5, 2023 11:11

Remove Wrong values in ingress_from/egress_from fields

fe3e5d6

Fix Lint

f788a56

c2thorn requested changes Jun 5, 2023

View reviewed changes

Change description for deprecated resources

46943a5

c2thorn approved these changes Jun 5, 2023

View reviewed changes

hao-nan-li merged commit 27b2e97 into GoogleCloudPlatform:main Jun 5, 2023

This was referenced Jun 5, 2023

Add ACM policies fine grained resources hashicorp/terraform-provider-google-beta#5723

Merged

Add ACM policies fine grained resources hashicorp/terraform-provider-google#14817

Merged

hao-nan-li mentioned this pull request Aug 18, 2023

Feature request: google_access_context_manager_service_perimeter_ingress_policy and google_access_context_manager_service_perimeter_egress_policy resources hashicorp/terraform-provider-google#12927

Closed

	# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter/IngressPolicy
	# Skipping the sweeper due to the non-standard base_url and because this is fine-grained under ServicePerimeter

Add ACM policies fine grained resources #8038

Add ACM policies fine grained resources #8038

Conversation

hao-nan-li commented May 30, 2023

modular-magician commented May 30, 2023

Diff report

Missing test report

modular-magician commented May 30, 2023

Tests analytics

modular-magician commented May 30, 2023

Diff report

Missing test report

modular-magician commented May 30, 2023

Tests analytics

modular-magician commented May 30, 2023

Diff report

Missing test report

modular-magician commented May 31, 2023

Tests analytics

Action taken

modular-magician commented May 31, 2023

hao-nan-li commented May 31, 2023

modular-magician commented Jun 1, 2023

Diff report

Missing test report

modular-magician commented Jun 1, 2023

Tests analytics

Action taken

modular-magician commented Jun 1, 2023

modular-magician commented Jun 2, 2023

Diff report

Missing test report

modular-magician commented Jun 2, 2023

Tests analytics

Action taken

modular-magician commented Jun 2, 2023

hao-nan-li commented Jun 2, 2023

modular-magician commented Jun 2, 2023

Diff report

Missing test report

modular-magician commented Jun 2, 2023

Tests analytics

Action taken

modular-magician commented Jun 2, 2023

c2thorn left a comment

Choose a reason for hiding this comment

c2thorn Jun 5, 2023

Choose a reason for hiding this comment

c2thorn Jun 5, 2023

Choose a reason for hiding this comment

c2thorn Jun 5, 2023

Choose a reason for hiding this comment

c2thorn Jun 5, 2023

Choose a reason for hiding this comment

hao-nan-li commented Jun 5, 2023

modular-magician commented Jun 5, 2023

Diff report

Missing test report

modular-magician commented Jun 5, 2023

Tests analytics

Action taken

c2thorn Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

c2thorn Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

hao-nan-li Jun 5, 2023

Choose a reason for hiding this comment

c2thorn Jun 5, 2023

Choose a reason for hiding this comment

hao-nan-li Jun 5, 2023

Choose a reason for hiding this comment

modular-magician commented Jun 5, 2023

modular-magician commented Jun 5, 2023

Diff report

Missing test report

c2thorn left a comment

Choose a reason for hiding this comment

modular-magician commented Jun 5, 2023

Tests analytics

Action taken

c2thorn Jun 5, 2023 •

edited

Loading

c2thorn Jun 5, 2023 •

edited

Loading