Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BYOIP by adding new resources #13516

Closed
SarahFrench opened this issue Jan 18, 2023 · 4 comments
Closed

Add support for BYOIP by adding new resources #13516

SarahFrench opened this issue Jan 18, 2023 · 4 comments

Comments

@SarahFrench
Copy link
Member

SarahFrench commented Jan 18, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

There is a feature that allows Bring Your Own IP (BYOIP) with VPCs 👉 https://cloud.google.com/vpc/docs/bring-your-own-ip
That guide describes how public advertised prefixes and public delegated prefixes are required to allow the IP(s) to be used, and those resources aren't implemented in the provider yet.

New or Affected Resource(s)

  • google_compute_public_advertised_prefix
  • google_compute_public_delegated_prefix

Potential Terraform Configuration

I'm unsure what the configuration would look like as the API documentation says this for both API endpoints:

There is no persistent data associated with this resource.

But using the JSON from the insert method docs for publicAdvertisedPrefixes it might look something like:

resource "google_compute_public_advertised_prefix" "example" {
    name = "example.com" # must match https://www.ietf.org/rfc/rfc1035.txt
    description = "Description goes here"
    ip_cidr_range = "1.2.3.4/5"
    parent_prefix = google_compute_public_delegated_prefix.self_link
    # other fields, possibly...
}

I think there would also need to be data sources implemented to access this data, given that there are no resources in a typical CRUD sense for this API endpoint. E.g. the docs for the fingerprint field of a PAP say "To see the latest fingerprint, make a get() request to retrieve a PublicDelegatedPrefix.".

References

@Harmelodic
Copy link

Is there an ETA or target date for releasing this?
(couple of weeks? particular month? Q2/3/4 2023? 2024?)

@slevenick
Copy link
Collaborator

End of April is the ETA

@rileykarson
Copy link
Collaborator

Fixed in GoogleCloudPlatform/magic-modules#7682

Should go out the week after next (24th)

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants