Compute public advertised prefixes #7682

slevenick · 2023-04-10T21:55:37Z

Adds PublicAdvertisedPrefix and PublicDelegatedPrefix resources. These are immutable though they have a PATCH method in the API because the PATCH method is only allowed to act on members of the publicDelegatedPrefixs field which are better represented as their own resources.

Creating a PAP requires reverse DNS verification, so we use a special loopback IP range and special description (encrypted so as not to publicize this test-only value) to create a test resource. Because we use a specific IP range and quotas for PAPs are very low the tests are handwritten and run in serial to prevent conflict.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_public_advertised_prefix`

`google_compute_public_delegated_prefix`

modular-magician · 2023-04-10T21:55:52Z

Oops! It looks like you're using unknown release-note types in your changelog entries:

new_resource
new_resource

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-04-10T22:14:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1515 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1515 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
TF Validator: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_public_advertised_prefix (0 total tests)
Untested fields: dns_verification_ip, ip_cidr_range, name, description

Please add acceptance tests which include these fields.
Resource: google_compute_public_delegated_prefix (0 total tests)
Untested fields: ip_cidr_range, description, is_live_migration, region, name, parent_prefix

Please add acceptance tests which include these fields.

modular-magician · 2023-04-10T22:16:15Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-04-10T22:48:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))
TF Validator: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_public_advertised_prefix (0 total tests)
Untested fields: dns_verification_ip, ip_cidr_range, name, description

Please add acceptance tests which include these fields.
Resource: google_compute_public_delegated_prefix (0 total tests)
Untested fields: ip_cidr_range, name, parent_prefix, region, description, is_live_migration

Please add acceptance tests which include these fields.

shuyama1 · 2023-04-10T22:49:32Z

/gcbrun

modular-magician · 2023-04-10T22:49:47Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

slevenick · 2023-04-10T22:50:04Z

As noted, tested fields aren't being captured correctly due to the handwritten tests.

is_live_migration is not tested because I was unable to correctly set up a PDP with that flag configured. There are restrictions on enabling it, projects must be opted-in explicitly

modular-magician · 2023-04-10T23:04:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))
TF Validator: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_public_advertised_prefix (0 total tests)
Untested fields: name, description, dns_verification_ip, ip_cidr_range

Please add acceptance tests which include these fields.
Resource: google_compute_public_delegated_prefix (0 total tests)
Untested fields: description, is_live_migration, ip_cidr_range, name, parent_prefix, region

Please add acceptance tests which include these fields.

modular-magician · 2023-04-10T23:21:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))
TF Validator: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_public_advertised_prefix (0 total tests)
Untested fields: name, description, dns_verification_ip, ip_cidr_range

Please add acceptance tests which include these fields.
Resource: google_compute_public_delegated_prefix (0 total tests)
Untested fields: name, parent_prefix, region, description, is_live_migration, ip_cidr_range

Please add acceptance tests which include these fields.

modular-magician · 2023-04-11T00:13:13Z

Tests analytics

Total tests: 2565
Passed tests 2286
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputePublicPrefixes|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-11T00:27:20Z

Tests passed during RECORDING mode:
TestAccComputePublicPrefixes[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

shuyama1

LGTM! Only small comments

shuyama1 · 2023-04-11T21:58:22Z

mmv1/products/compute/PublicDelegatedPrefix.yaml

+    name: 'region'
+    description: 'A region where the prefix will reside.'
+    url_param_only: true
+    immutable: true


Do we still need to set it explicitly, given the resource is immutable?

shuyama1 · 2023-04-11T21:58:34Z

mmv1/products/compute/PublicDelegatedPrefix.yaml

+    name: 'parentPrefix'
+    description: The URL of parent prefix. Either PublicAdvertisedPrefix or PublicDelegatedPrefix.
+    required: true
+    immutable: true


rileykarson · 2023-04-12T21:59:14Z

@shuyama1: Want to pick this up while Sam's OOO? I can review the delta.

shuyama1 · 2023-04-12T22:02:15Z

@shuyama1: Want to pick this up while Sam's OOO? I can review the delta.

Sure! Taking a look now

modular-magician · 2023-04-13T00:02:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1345 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))
TF Validator: Diff ( 4 files changed, 199 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_public_advertised_prefix (0 total tests)
Untested fields: dns_verification_ip, ip_cidr_range, name, description

Please add acceptance tests which include these fields.
Resource: google_compute_public_delegated_prefix (0 total tests)
Untested fields: description, is_live_migration, ip_cidr_range, name, parent_prefix, region

Please add acceptance tests which include these fields.

modular-magician · 2023-04-13T00:53:18Z

Tests analytics

Total tests: 2615
Passed tests 2335
Skipped tests: 277
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-04-13T01:07:32Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

rileykarson · 2023-04-13T16:18:09Z

FYI @slevenick I added backticks for the resource names: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md#unticked-resource-names

slevenick requested a review from a team as a code owner April 10, 2023 21:55

slevenick requested review from shuyama1 and removed request for a team April 10, 2023 21:55

slevenick force-pushed the compute-pap branch from fea1c43 to 72e4fbf Compare April 10, 2023 22:31

shuyama1 approved these changes Apr 11, 2023

View reviewed changes

slevenick and others added 9 commits April 12, 2023 16:37

Add PAP

c3c00a3

Add tests using env variable description

ff0b656

Single handwritten test

9c28c91

Fix tests

35ae3be

Add default to examples

705af35

Public function fix

b6b6050

Fix PreCheck name

5419c1d

Remove extra immutable

3daf581

resolve conflicts

48e147e

shuyama1 force-pushed the compute-pap branch from 7aa3c4f to 48e147e Compare April 12, 2023 23:46

rileykarson approved these changes Apr 13, 2023

View reviewed changes

shuyama1 merged commit 636581c into GoogleCloudPlatform:main Apr 13, 2023

rileykarson mentioned this pull request Apr 13, 2023

Add support for BYOIP by adding new resources hashicorp/terraform-provider-google#13516

Closed

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Compute public advertised prefixes (GoogleCloudPlatform#7682)

3696f77

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compute public advertised prefixes #7682

Compute public advertised prefixes #7682

slevenick commented Apr 10, 2023 •

edited by rileykarson

Loading

modular-magician commented Apr 10, 2023

modular-magician commented Apr 10, 2023

modular-magician commented Apr 10, 2023

modular-magician commented Apr 10, 2023

shuyama1 commented Apr 10, 2023

modular-magician commented Apr 10, 2023

slevenick commented Apr 10, 2023

modular-magician commented Apr 10, 2023

modular-magician commented Apr 10, 2023

modular-magician commented Apr 11, 2023

modular-magician commented Apr 11, 2023

shuyama1 left a comment

shuyama1 Apr 11, 2023

shuyama1 Apr 11, 2023

rileykarson commented Apr 12, 2023

shuyama1 commented Apr 12, 2023

modular-magician commented Apr 13, 2023

modular-magician commented Apr 13, 2023

modular-magician commented Apr 13, 2023

rileykarson commented Apr 13, 2023

Compute public advertised prefixes #7682

Compute public advertised prefixes #7682

Conversation

slevenick commented Apr 10, 2023 • edited by rileykarson Loading

modular-magician commented Apr 10, 2023

modular-magician commented Apr 10, 2023

Diff report

Missing test report

modular-magician commented Apr 10, 2023

Tests analytics

modular-magician commented Apr 10, 2023

Diff report

Missing test report

shuyama1 commented Apr 10, 2023

modular-magician commented Apr 10, 2023

Tests analytics

slevenick commented Apr 10, 2023

modular-magician commented Apr 10, 2023

Diff report

Missing test report

modular-magician commented Apr 10, 2023

Diff report

Missing test report

modular-magician commented Apr 11, 2023

Tests analytics

Action taken

modular-magician commented Apr 11, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 Apr 11, 2023

Choose a reason for hiding this comment

shuyama1 Apr 11, 2023

Choose a reason for hiding this comment

rileykarson commented Apr 12, 2023

shuyama1 commented Apr 12, 2023

modular-magician commented Apr 13, 2023

Diff report

Missing test report

modular-magician commented Apr 13, 2023

Tests analytics

Action taken

modular-magician commented Apr 13, 2023

rileykarson commented Apr 13, 2023

slevenick commented Apr 10, 2023 •

edited by rileykarson

Loading