Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'labels' field for the GKEHub Tenancy API resources #15708

Comments

@sahsagar-google
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The namespace labels(as applicable) and labels fields are missing from the tenancy API resources for GKEHub and it will be really helpful for the customers to be able to use them.

New or Affected Resource(s)

  • google_gke_hub_scope_rbac_role_binding
  • google_gke_hub_membership_binding
  • google_gke_hub_membership_rbac_role_binding
  • google_gke_hub_scope

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

  • #0000
@sahsagar-google
Copy link
Author

I am working on this!

@github-actions github-actions bot added forward/review In review; remove label to forward service/gkehub labels Sep 1, 2023
@rileykarson rileykarson added size/s and removed forward/review In review; remove label to forward labels Sep 5, 2023
@rileykarson rileykarson added this to the Goals milestone Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.