Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels field to the GKEHub Scope resource and make it updatable #15801

Conversation

modular-magician
Copy link
Collaborator

Fixes #15708

Release Note Template for Downstream PRs (will be copied)

gkehub: added `labels` fields to `google_gke_hub_scope` resource

Derived from GoogleCloudPlatform/magic-modules#8882

…ashicorp#8882)

* Adding Terraform resources for Tenancy APIs in GKEHub

* Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review

* Fixing the docu URIs

* Adding TF support for Tenancy API for Membership Binding

* Adding dependent membership binding to the same commit chain

* Making Scope un-updatable and replacing hard coded project number with the one from test env

* Making Scope RRBAC updatable

* Making Namespace immutable

* Adding update test cases

* Removing all memberships field from Scope since it is no longer supported

* Removing all_memberships field for Scope from all test cases

* Adding labels field to the GKEHub Scope resource

* Fixing typo in the comment

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 77fa016 into hashicorp:main Sep 11, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'labels' field for the GKEHub Tenancy API resources
1 participant