Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver Monitoring Custom Metric #3360

Comments

@ocervell
Copy link

ocervell commented Apr 2, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Need a resource to create custom metrics through Stackdriver Monitoring API.
API Documentation for custom metrics is available here.

New or Affected Resource(s)

  • google_monitoring_metric_descriptor

Potential Terraform Configuration

resource "google_monitoring_metric_descriptor" {
  project_id="project_test_123"
  description="Daily sales records from all branch stores."
  display_name="daily sales"
  type="custom.googleapis.com/stores/daily_sales"
  metric_kind="GAUGE"
  value_type="DOUBLE"
  unit="{USD}"
  labels=[
    {
      key="store_id",
      value_type="STRING",
      description="The ID of the store."
    }
  ]
}
  • #0000
@ghost ghost added the enhancement label Apr 2, 2019
@rileykarson
Copy link
Collaborator

Hey @ocervell! We weren't able to get this working up to our standards with Terraform due to issues with the underlying API, so we're not currently interested in adding this resource. That said, we'll leave this open to track interest in the feature.

@ocervell
Copy link
Author

@rileykarson Could you expand a little on what issues in particular the underlying API has ? Is it the lack of an update method ?

@chrisst
Copy link
Contributor

chrisst commented Dec 11, 2019

@ocervell IIRC there were a few issues with the underlying API that our code generator didn't handle well yet, such as lack of Operation objects for an async request and non standard HTTP codes. Additionally I got guidance from the API team that API descriptors should be automatically created for most scenarios and that custom metric descriptors should be exceptional. So at the time I chose to focus on getting alert policy and the other monitoring resources out over this one.

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Apr 22, 2020
* Added artifact registry product

* Artifact Registry fixes

* Switched property from region -> location

Also fixed incorrect import error message

* Add artifact registry links to website

Co-authored-by: Chris Stephens <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Apr 22, 2020
* Added artifact registry product

* Artifact Registry fixes

* Switched property from region -> location

Also fixed incorrect import error message

* Add artifact registry links to website

Co-authored-by: Chris Stephens <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Chris Stephens <[email protected]>
@agadelshin
Copy link

One year later I'd like to raise discussion again:

  1. does stackdriver API still have this problems?
  2. if it does, how can we motivate stackdriver team to fix it?

@tishen25
Copy link

Started working on this

@ghost
Copy link

ghost commented Aug 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.