-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document id
field for resources
#5542
Document id
field for resources
#5542
Comments
We should also probably update our examples/tests to use it cc @slevenick since we were talking about this for a bit earlier |
Riley to add more details before this goes to bug triage folks |
* fixed ids for hashicorp#5542 * fixed ids for hashicorp#5542 and replacing self_links * fixed ids for hashicorp#5542 * Update datasource_google_compute_backend_service.html.markdown (forcing update to build) * Updated id value Co-authored-by: edward <[email protected]> Co-authored-by: emily <[email protected]> Signed-off-by: Modular Magician <[email protected]>
* fixed ids for #5542 * fixed ids for #5542 and replacing self_links * fixed ids for #5542 * Update datasource_google_compute_backend_service.html.markdown (forcing update to build) * Updated id value Co-authored-by: edward <[email protected]> Co-authored-by: emily <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: edward <[email protected]> Co-authored-by: emily <[email protected]>
@edwardmedia did GoogleCloudPlatform/magic-modules#3205 fix every id, or are some remaining? |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The work is complete. Some examples remain unchanged as their tests are failing. |
@edwardmedia do you have a list of examples that this doesn't work for? It would be worth having that so we can fix the resources in question. |
In
3.0.0
, we changed Terraform's internalid
field from formats like{{project}}/{{region}}/{{name}}
toprojects/{{project}}/regions/{{region}}/resources/{{name}}
, a valid reference value.Historically we've encouraged users to use
name
orself_link
as the reference value, however these values should be preferred going forward. We've since documented the field on generated resources, but no examples or tests have been updated and neither have handwritten resources.For this issue:
id
output-only attribute including the expected format (see Add docs for the id field GoogleCloudPlatform/magic-modules#3040 downstreams for samples)id
as the reference value if it makes sense / worksThis should happen in small groups (~3-7 resources) so the PRs are easy to test and not overwhelming.
The text was updated successfully, but these errors were encountered: