Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document] Duplicate content blocks in google_compute_url_map #6584

Closed
edwardmedia opened this issue Jun 12, 2020 · 3 comments
Closed

[Document] Duplicate content blocks in google_compute_url_map #6584

edwardmedia opened this issue Jun 12, 2020 · 3 comments

Comments

@edwardmedia
Copy link
Contributor

edwardmedia commented Jun 12, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

  • google_compute_url_map

Important Factoids

As an example, The request_headers_to_add block supports: section appears 5 times in the document

  • #0000
@ghost ghost added the bug label Jun 12, 2020
@edwardmedia edwardmedia changed the title [Document] The xxxxx block supports: repeats in google_compute_url_map [Document] Duplicate blocks in google_compute_url_map Jun 12, 2020
@edwardmedia edwardmedia changed the title [Document] Duplicate blocks in google_compute_url_map [Document] Duplicate content blocks in google_compute_url_map Jun 12, 2020
@c2thorn
Copy link
Collaborator

c2thorn commented Jun 25, 2020

Looking at the api.yaml file that generated the docs, blocks like request_headers_to_add appear in several different fields legitimately and even have differences in them (like Required vs Optional) that would be good to point out. The generated documentation is pretty confusing though, I think better marking or navigation would be better by providing the attribute tree:

google_compute_url_map.header_action.request_headers_to_add
google_compute_url_map.path_matchers.header_action.request_headers_to_add

So I believe this should be considered a potential doc generation enhancement instead of a bug since there is a difference technically.

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Sep 28, 2022
…gle_compute_backend_service (hashicorp#6584)

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Sep 28, 2022
…gle_compute_backend_service (#6584) (#12674)

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
@rileykarson rileykarson removed the bug label Mar 6, 2023
@rileykarson
Copy link
Collaborator

We could consider doing #6091 (or a similar fix) to resolve this

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants