Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccContainerCluster_withReleaseChannelEnabled test #6593

Closed
rileykarson opened this issue Jun 15, 2020 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#3762 or hashicorp/terraform-provider-google-beta#2286

Comments

@rileykarson
Copy link
Collaborator

No description provided.

@rileykarson
Copy link
Collaborator Author

I took a look at this and don't have a great solution- we test upgrading between release channels, but it's an impossible transition right now. The STABLE and REGULAR channel are 2 minor versions apart, which is an impossible transition (you can only upgrade a single minor version at a time).

This doesn't have much to do with release channels- we actually turn the feature off to perform the transition. We could consider handling big version jumps natively in the provider by selecting appropriate intermediary GKE versions, but that's likely undesirable. The logic would be brittle, and TF choosing arbitrary (temporary) minor versions could be an anti-feature. Instead, we could consider removing the update mechanics from the test- unfortunate, since it stops testing a complex interaction- but will make the test pass again.

@ghost
Copy link

ghost commented Aug 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.