Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate default version update from release channel test #3762

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 21, 2020

Fixes hashicorp/terraform-provider-google#6593

Separate the default version test from the release enabled tests as we can't update over 2 minor versions.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Jul 21, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 14 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134568"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134569"

@megan07 megan07 requested a review from rileykarson July 21, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccContainerCluster_withReleaseChannelEnabled test
3 participants