Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Config Patch Deployment is missing rollout option #7124

Closed
cookejames opened this issue Aug 27, 2020 · 2 comments
Closed

OS Config Patch Deployment is missing rollout option #7124

cookejames opened this issue Aug 27, 2020 · 2 comments

Comments

@cookejames
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The rollout option is missing from patch deployment.

New or Affected Resource(s)

  • google_os_config_patch_deployment

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_os_config_patch_deployment" "patch" {
  patch_deployment_id = "patch-deploy-inst"

  rollout {
    mode = ZONE_BY_ZONE
    disruption_budget {
      fixed = 1
    }
  }

  instance_filter {
    all = true
  }

  recurring_schedule {
    time_zone {
      id = "America/New_York"
    }

    time_of_day {
      hours = 1
    }

    weekly {
      day_of_week = "MONDAY"
    }
  }
}

References

No

@ghost ghost added the enhancement label Aug 27, 2020
@cookejames
Copy link
Author

PR created in GoogleCloudPlatform/magic-modules#3919

@danawillow danawillow added this to the Near-Term Goals milestone Aug 31, 2020
modular-magician added a commit to modular-magician/docs-examples that referenced this issue Sep 1, 2020
…form-provider-google#7124 (#3919)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to terraform-google-modules/docs-examples that referenced this issue Sep 1, 2020
…form-provider-google#7124 (#3919) (#81)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-google-conversion that referenced this issue Sep 1, 2020
…form-provider-google#7124 (#3919)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to GoogleCloudPlatform/terraform-google-conversion that referenced this issue Sep 1, 2020
…form-provider-google#7124 (#3919) (#515)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Sep 1, 2020
…ashicorp#3919)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Sep 1, 2020
…7172)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Sep 1, 2020
…form-provider-google#7124 (hashicorp#3919)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Sep 1, 2020
…form-provider-google#7124 (#3919) (#2449)

* Add rollout option to osconfig patch deployment

* Add test

* Set properties to required and correctly specify exactly one of

* Fix typos

Signed-off-by: Modular Magician <[email protected]>
@ghost
Copy link

ghost commented Oct 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants