Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_dns_record_set create record override #7190

Closed
bdronneau opened this issue Sep 3, 2020 · 3 comments
Closed

google_dns_record_set create record override #7190

bdronneau opened this issue Sep 3, 2020 · 3 comments

Comments

@bdronneau
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In the documentation dns_record_set there is a note

Note: The provider treats this resource as an authoritative record set. This means existing records (including the default records) for the given type will be overwritten when you create this resource in Terraform. In addition, the Google Cloud DNS API requires NS records to be present at all times, so Terraform will not actually remove NS records during destroy but will report that it did.

In 2.8.0 this behavior was limit to NS record. In 2.9.0 this behavior was applied to all records types.
This behavior is normal for update recordSet, but on creation, I think a option to block override on creation can be usefull.

New or Affected Resource(s)

  • google_dns_record_set

Potential Terraform Configuration

resource "google_dns_record_set" "frontend" {
  name = "frontend.${google_dns_managed_zone.prod.dns_name}"
  type = "A"
  ttl  = 300
  create_override = false

  managed_zone = google_dns_managed_zone.prod.name

  rrdatas = [google_compute_instance.frontend.network_interface[0].access_config[0].nat_ip]
}

References

  • None
@ghost ghost added enhancement labels Sep 3, 2020
@danawillow danawillow added this to the Backlog milestone Sep 8, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Feb 8, 2023
@rileykarson
Copy link
Collaborator

We're not sure there's enough context to actually take action here, so I'm going to close it out. If this is still of interest / needed, please feel free to open a new request!

@bdronneau
Copy link
Contributor Author

Hello,

Not interested for now, since I am not dealing with GCP at work, maybe in futur I will come back here :)

Which context is missing ?

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants