Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test(s): TestAccPrivatecaCertificate_privatecaCertificateCsrExample #9999

Closed
melinath opened this issue Sep 2, 2021 · 5 comments · Fixed by GoogleCloudPlatform/magic-modules#6907, terraform-google-modules/docs-examples#333, hashicorp/terraform-provider-google-beta#4950 or #13182
Closed

Failing test(s): TestAccPrivatecaCertificate_privatecaCertificateCsrExample #9999

melinath opened this issue Sep 2, 2021 · 5 comments · Fixed by GoogleCloudPlatform/magic-modules#6907, terraform-google-modules/docs-examples#333, hashicorp/terraform-provider-google-beta#4950 or #13182
Labels
forward/linked service/privateca size/s test-failure
Milestone
Near-Term Goals

Comments

@melinath
Copy link
Collaborator

melinath commented Sep 2, 2021

Failure rate: 10% in August

Impacted tests:

  • TestAccPrivatecaCertificate_privatecaCertificateCsrExample

Nightly builds:

Message:

Error: Error waiting for Deleting CertificateAuthority: Error code 9, message: CA has un-revoked or un-expired certificates. Please revoke any active certificates and try again. Alternatively, you can add the `ignore_active_certificates` parameter to the request to skip this check.
@melinath melinath changed the title Failing test(s): TestAccPrivatecaCertificate_privatecaCertificateCsrExample Failing test(s): TestAccPrivatecaCertificate_privatecaCertificateCsrExample (beta) Sep 2, 2021
@rileykarson rileykarson added this to the Near-Term Goals milestone Sep 13, 2021
@melinath melinath changed the title Failing test(s): TestAccPrivatecaCertificate_privatecaCertificateCsrExample (beta) Failing test(s): TestAccPrivatecaCertificate_privatecaCertificateCsrExample Oct 28, 2022
@melinath
Copy link
Collaborator Author

melinath commented Oct 28, 2022 •
edited
Loading

This was promoted to GA.

@melinath
Copy link
Collaborator Author

b/259261674

@gfxcc
Copy link
Contributor

gfxcc commented Nov 30, 2022

This should not be an issue now as we revoke certificate on deletion.

Rerun the test and passed.

@melinath could you check if this is still an issue and close the issue if this is not needed.

@melinath
Copy link
Collaborator Author

@gfxcc it looks like it's still failing ~10% of the time as of Nov. 2022 - was there a recent change?

@gfxcc gfxcc mentioned this issue Dec 2, 2022
Merged
5 tasks
ScottSuarez pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Dec 6, 2022
@gfxcc
Disable CA deletion related protection in tests (#6907)
a928ed8 
fixes hashicorp/terraform-provider-google#9999
modular-magician added a commit to modular-magician/docs-examples that referenced this issue Dec 6, 2022
@modular-magician
Disable CA deletion related protection in tests (#6907)
ea6e01c 
fixes hashicorp/terraform-provider-google#9999

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician mentioned this issue Dec 6, 2022
Merged
5 tasks
modular-magician added a commit to terraform-google-modules/docs-examples that referenced this issue Dec 6, 2022
@modular-magician
Disable CA deletion related protection in tests (#6907) (#333)
ffec46a 
fixes hashicorp/terraform-provider-google#9999

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Dec 6, 2022
@modular-magician
Disable CA deletion related protection in tests (hashicorp#6907)
07a4b0d 
fixes hashicorp/terraform-provider-google#9999

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 6, 2022
@modular-magician
Disable CA deletion related protection in tests (hashicorp#6907)
38909af 
fixes hashicorp#9999

Signed-off-by: Modular Magician <[email protected]>
This was referenced Dec 6, 2022
Merged
Merged
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Dec 6, 2022
@modular-magician
Disable CA deletion related protection in tests (#6907) (#4950)
187793d 
fixes hashicorp/terraform-provider-google#9999

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Dec 6, 2022
@modular-magician
Disable CA deletion related protection in tests (#6907) (#13182)
8805cc8 
fixes #9999

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this issue Dec 6, 2022
@gfxcc @kimihrr
Disable CA deletion related protection in tests (GoogleCloudPlatform#…
b42edbf 
…6907)

fixes hashicorp/terraform-provider-google#9999
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this issue Dec 6, 2022
@gfxcc @hao-nan-li
Disable CA deletion related protection in tests (GoogleCloudPlatform#…
88004bd 
…6907)

fixes hashicorp/terraform-provider-google#9999
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
forward/linked service/privateca size/s test-failure
Projects
None yet
Milestone
Near-Term Goals
3 participants
@melinath @rileykarson @gfxcc