Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve bug on bigquery routine documented in #10264 #10265

Closed
wants to merge 1 commit into from

Conversation

tgmof
Copy link

@tgmof tgmof commented Oct 6, 2021

See bug raised here:
#10264
TLDR: dataset_id and routine_id are part of the underlying google ID for a bigquery routine and thus the resource need to be re-created and can't be "renamed"

See bug raised here:
hashicorp#10264
TLDR: dataset_id and routine_id are part of the underling ID and thus the resource need to be re-created and can't be "renamed"
@tgmof tgmof changed the title Solve bug documented in issue 10264 Solve bug on bigquery routine documented in #10264 Oct 6, 2021
@nat-henderson
Copy link
Contributor

Got it. Unfortunately, this resource is code-generated, so changes made here will be reverted by the code generator on its next run. Can you make this change against the source of truth for this resource, the magic modules repository? That would be this file: https://github.com/GoogleCloudPlatform/magic-modules/blob/74a07369a9e42f935d25820cb439b07f3ff1d6d8/mmv1/products/bigquery/api.yaml.

I believe you want to set input: true on the two relevant fields.

@nat-henderson
Copy link
Contributor

I went ahead and did that: GoogleCloudPlatform/magic-modules#5298 - thanks for the report!

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants