Default enable_shielded_nodes to true
#10403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
ameukam
added a commit
to ameukam/k8s.io
that referenced
this pull request
Nov 2, 2021
Prepare the upgrade to 4.0.0 for the GCP terraform providers: - bump the provider to 3.90.1 - remove fields unsupport in 4.0.0. The fieds unsupported in 4.0.0 can be found here: https://registry.terraform.io/providers/hashicorp/google-beta/latest/docs/guides/version_4_upgrade#resource-google_container_cluster - ensure Shielded Nodes feature is disabled. See: hashicorp/terraform-provider-google#10403 Signed-off-by: Arnaud Meukam <[email protected]>
brianpham
added a commit
to brianpham/terraform-google-gke
that referenced
this pull request
Nov 10, 2021
* Add variable for enabled_shieled_nodes hashicorp/terraform-provider-google#10403 * Add required client_certificate_config and remove username and password from master_auth hashicorp/terraform-provider-google#10441 * Update workload_identity_config to use workload pool instead of identity_namespace hashicorp/terraform-provider-google#10410
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9122
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5263