Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role arn #10950

Conversation

modular-magician
Copy link
Collaborator

Adds the option to use role_arn for the transfer service resource. Fixes #10880.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.

I did generate this and make sure it could build. make test and make lint didn't do anything because there was no rule for the make target.

  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).

Looks like S3 sources aren't supported in the third party tests. Probably because it would require infrastructure to create resources in AWS S3?

  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).

There aren't any relevant tests as far as I know.

Release Note Template for Downstream PRs (will be copied)

storage: added field `transfer_spec.aws_s3_data_source.role_arn` to `google_storage_transfer_job`

Derived from GoogleCloudPlatform/magic-modules#5619

* Adds support for role_arn for storage_transfer_job

* Fix syntax error

* Fix build error.

* Adds ExactlyOneOf check.

Co-authored-by: Joseph Cox <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 22e72b1 into hashicorp:master Jan 21, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add google_storage_transfer_job support for AWS RoleArn for temporary credentials
1 participant