Create data sources for tag_keys and tag_values #11753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates data sources for
google_tags_tag_key
andgoogle_tags_tag_vaule
resources, so that they can be looked up by parent and short_name and one can avoid opaque magic numbers in one's Terraform configuration using tags.Part of #11367 - the end goal of that issue may not be addressed unless the GCP IAM Tags API changes; until then these resources will accomplish the same goal, albeit in a roundabout fashion.
I borrowed heavily from the
google_active_folder
data source when writing this code. Hopefully I didn't miss any copypasta.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6042