Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reading data_disk_type value from API response into state of google_notebooks_instance resource #12493

Conversation

modular-magician
Copy link
Collaborator

Description

Fixes #8485

That issue linked above describes a permadiff/permadelete situation where:

  • the Terraform config defines a type of disk to use in data_disk_type
  • the notebook resource is created
  • after creation, TF reads the resource from the API and overwrites state
  • The API response doesn't include the data_disk_type value, so it is set to "" in state
  • On the next plan TF identifies that the config has a non-zero value and the state has a zero value, so proposes a change
  • The change is on a ForceNew field

This PR stops the data_disk_type value being read from the API to overwrite state.

This matches how the boot disk arguments are handled:

https://github.com/GoogleCloudPlatform/magic-modules/blob/ea34ac204ae9216682497593ad5e383a16585ff3/mmv1/products/notebooks/terraform.yaml#L70-L73

List

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). N/A
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
    • Tests starting TestAccNotebooksInstance_ pass
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

notebooks: fixed perma-diff in `google_notebooks_instance`

Derived from GoogleCloudPlatform/magic-modules#6512

…gle_notebooks_instance resource (hashicorp#6512)

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 30a3620 into hashicorp:main Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State is not properly tracked when using data_disk_type on google_notebooks_instance resource
1 participant