Allow subordinate CA data sources in all states #12511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12432
Currently, attempting to use a
google_privateca_certificate_authority
for aSUBORDINATE
CA in any state other thanAWAITING_USER_ACTIVATION
is impossible, because the Google API can only fetch the CSR in that state (reference). This prevents some really common use cases, like pulling an existing subordinate CA to issue leaf certs.With this change, pulling a subordinate CA in any state other than
AWAITING_USER_ACTIVATION
will result inpem_csr
simply being unset. If the subordinate CA is inAWAITING_USER_ACTIVATION
and the CSR fetch fails, an error will still be thrown as expected.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6496