Alloydb cluster #12772
Merged
Alloydb cluster #12772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* basic resource + import * add computed sources * more args * fix network * fix types for duration * instance * Update mmv1/products/alloydb/api.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/products/alloydb/api.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/products/alloydb/api.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * create network for test * remove excludes + machineConfig * cluster_id * cluster_id * revert * use parent resource * use parent resource * add selflink * alloydb tests * beta * import * imports * add conflicts * revert * revert * revert * revert * Apply suggestions from code review Co-authored-by: Cameron Thornton <[email protected]> * reduce only to cluster resource * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * remove fields * full example * full test + validations * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unneeded arg * CR - remove unspecified enums * remove unneeded arg * remove unneeded arg * tests passing * Update mmv1/products/alloydb/api.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove fields * remove kms * remove kms * fix rebase * CR comments * CR comments Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #6208
Relates of #11754
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6507