feat(vertexai): add google_vertex_ai_index for Vertex AI Matching Engine #13132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine (hashicorp#6728) * feat: add google_vertex_ai_index for Vertex AI Matching Engine * fix: increase timeouts to 60 min because 20 wasn't enough for creation * fix: change coe to make name computed instead of an input * fix: use costom flatten code to ignore_read a nested property's field * fix: add skip_import_test: true to the auto-gen test * feat: add a test with a manually updated ImportStateVerifyIgnore * Apply suggestions from code review [ci skip] Update descriptions based on the suggestions Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * refactor: use ignore_read_extra instead of a manual test * fix: use an empty object for bruteForceConfig * feat: define additional fields to api.yaml * feat: add an example to increase test coverage * feat: deal with contentsDeltaUri as an updatable field * fix: fix the error because the cosine distance type only supports unit l2 norm type This is the error message from the endpoint: "Index with `COSINE_DISTANCE` distanceMeasureType currently only supports `UNIT_L2_NORM` featureNormType." * feat: remove approximate_neighbors_count from an example with brute_force_config approximate_neighbors_count is required if tree-AH algorithm is used. from https://cloud.google.com/vertex-ai/docs/matching-engine/configuring-indexes#brute-force-config * test: add a handwritten test for patch * fix: add update_mask: true to use the mask as a url param * refactor: put 'input: true' on the fields patch couldn't update * feat: use custom pre update code for a nested object * fix: update the handwritten test accordingly * feat: add custom flatten code for is_complete_overwrite Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12818
Part of #9298
Add
google_vertex_ai_indexto create an index for Vertex AI Matching Engine.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6728