Support location in google tags tag binding #13524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* working on tags issue * added handwritten resource for location_tags * reverting_ruby_version * fixing_the_test_of_location_tag_binding * fixing_the_test_og_tags_location_tag_binding * fixing the test case of location_tag_binding * fixing the test case of location tag binding * fix_the_test_case_of_location_tag_binding * fixing_the_test_and_added_different_destroy_producer * fixing_the_test_case_of_location_tag_binding * reverting some changes in test case * adding new test file for location tag binding * added a seprate test file for location tag binding * added autogen exception in test file of location tag binding * making_GA_only_resource_tags_location_tag_binding * adding the test in common test file * changing the test config in acceptance test of location_tag_binding * minor fixes * fixing the linting error * minor fixes * minor fixes * committing to run pipeline * reverting-ruby-version * running pipline for debugging * changin the IAM permission in tags test * added permission for cloud run instance * added permission for cloud run instance * added permission for cloud run instance in acceptance test * adding IAM policy to test case of location_tags_binding * changing the IAM role in test case of location_tag_binding * adding the iam binding for cloudrun service in the test case of location_tag_binding * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * minor fixes * re-running the pipeline * minor linting fixes * added the docs * handling pagination in Read method of resource * fixing linting errors * minor fixes * fixing the minor errors * fixing the minor errors * changing the id format * fixing import function * updating the docs * fixing linting error * fixing linting error * fixing the import statement * minor fixes and adding import_state_verify * minor fix * addressing the review comments * addressing the review comments * commiting to run pipeline Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue : Add location attribute to google_tags_tag_binding
Proposing New Resource Because of this issue : Support location being in the domain of a resource's URLs for only a subset of resources in an MMv1 service
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6716