Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deletion_policy a virtual_field for AndroidApp and AppleApp #13643

Conversation

modular-magician
Copy link
Collaborator

Similar to #6738, make deletion_policy a virtual field to avoid forced replacement on update.

If this PR is for Terraform, I acknowledge that I have:

  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

firebase: marked `deletion_policy` as updatable without recreation on `google_firebase_android_app` and `google_firebase_apple_app`

Derived from GoogleCloudPlatform/magic-modules#6911

…hicorp#6911)

* Make deletion_policy a virtual_field for AndroidApp and AppleApp similar to hashicorp#6738

* Accomodate upstream comments and inconsistent patches

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 5c958f3 into hashicorp:main Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant