Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PollCheckKnativeStatusFunc check if observedGeneration is less-than instead of not-equal #14087

Merged
merged 1 commit into from
Mar 24, 2023
Merged

PollCheckKnativeStatusFunc check if observedGeneration is less-than instead of not-equal #14087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/7520.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
cloudrun: Fixed race condition when polling for status during an update of a `google_cloud_run_service`
```
2 changes: 1 addition & 1 deletion google/cloudrun_polling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func PollCheckKnativeStatusFunc(knativeRestResponse map[string]interface{}) func
if err != nil {
return ErrorPollResult(errwrap.Wrapf("unable to find Knative generation: {{err}}", err))
}
if int(s.Status.ObservedGeneration) != gen {
if int(s.Status.ObservedGeneration) < gen {
return PendingStatusPollResult("waiting for observed generation to match")
}
for _, condition := range s.Status.Conditions {
Expand Down