Fix firebase_project to succeed on apply when the project already has firebase enabled #14121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14036
This fixes an issue where if a project already had Firebase enabled,
terraform apply
would fail with a 409 error. This was problematic because Firebase cannot be disabled, so while a user would normally expect to be able to apply -> destroy -> apply successfully, it would fail on this resource.There was a workaround for users to import, but it was not ideal to force users to do this just for a single boolean setting.
Note that the proposed solution here matches how
project_service
currently works, where it first checks the API for the current state, and breaks early if there are no changes needed.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7523