Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert RIT changes from release branch #14183

Merged

Conversation

rileykarson
Copy link
Collaborator

@rileykarson rileykarson commented Apr 3, 2023

The GA API seems to have gone away- revert the whole feature (including beta)

git revert a97d0c89ed1842c9d21717c9387ba3595adf9742
git revert d9a84b596755d154872ec5c3a357e3459c001545

Note that d9a84b5 was an unclean revert due to #14128

Release plan:

  • Merge these changes
  • Run TestAccCompute against the release branch (~2h)
  • If successful, release tomorrow

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

Copy link
Collaborator

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented May 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants