Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for Ingress Policy #14361

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix test for Ingress Policy #14361

merged 1 commit into from
Apr 19, 2023

Conversation

modular-magician
Copy link
Collaborator

Fix test for Ingress Policy that failed during the nightly test run.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

accesscontextmanager: fixed test for `google_access_context_manager_ingress_policy`

Derived from GoogleCloudPlatform/magic-modules#7762

@modular-magician modular-magician merged commit 1f0fe47 into hashicorp:main Apr 19, 2023
SarahFrench pushed a commit that referenced this pull request Apr 20, 2023
@modular-magician @SarahFrench
Fix test for Ingress Policy (#7762) (#14361)
da00084 
Signed-off-by: Modular Magician <[email protected]>
lokemoon pushed a commit to lokemoon/terraform-provider-google that referenced this pull request May 3, 2023
@lokemoon-fwd
Squashed commit of the following:
6639e29 
commit cdc3a6191b6385db7920da141abf0267c858ac73
Author: NG, Loke Moon <[email protected]>
Date:   Wed May 3 22:23:57 2023 +0800

    update

commit 2fc4f59
Author: NG, Loke Moon <[email protected]>
Date:   Wed May 3 21:56:34 2023 +0800

    update

commit 3fe9839
Author: NG, Loke Moon <[email protected]>
Date:   Wed May 3 21:33:29 2023 +0800

    update .goreleaser.yaml

commit e42709b
Author: NG, Loke Moon <[email protected]>
Date:   Wed May 3 21:30:33 2023 +0800

    sync release.yaml with hashicups

commit 92b3a66
Author: NG, Loke Moon <[email protected]>
Date:   Wed May 3 21:24:40 2023 +0800

    test debug

commit dfd229c
Author: Stephen Lewis <[email protected]>
Date:   Wed Apr 26 10:32:49 2023 -0700

    Updated changelogs

commit fe26d99
Author: Modular Magician <[email protected]>
Date:   Wed Apr 26 16:29:26 2023 +0000

    fix: check if Bigtable cluster zones are affected by partial unavailability

commit d6ffceb
Author: Sarah French <[email protected]>
Date:   Mon Apr 24 17:05:07 2023 +0100

    Add CHANGELOG for v4.63.0 (hashicorp#14382)

    * Add CHANGELOG diff (unedited) for v4.63.0

    * Updated CHANGELOG to match style guide

    REmoved non user facing commits and reverted commits

    * Remove entry that was cherrypicked for v4.62.1

    * Reorder new resources into alphabetical order

    * Remove beta, consolidate alloydb notes into single NOTE entry and remove equivalent BUG FIXES entries

    * Update compute bugfix description

    * Add detail to `sql` bug release note

    * iamworkforcepool -> iam

    ---------

    Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

commit da00084
Author: The Magician <[email protected]>
Date:   Wed Apr 19 10:35:43 2023 -0700

    Fix test for Ingress Policy (hashicorp#7762) (hashicorp#14361)

    Signed-off-by: Modular Magician <[email protected]>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician