Fix inconsistent final plan when labels are added to resources #14594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users reported an issue creating buckets with labels via
google_storage_bucket
since #6518 was merged. Creation failed with the following error message:I am by far no Terraform expert but i looked at the other resources which had a
DiffSuppressFunc
set on theirlabels
property and all of them hadcomputed: true
EXCEPTgoogle_dataflow_job
. So i ran a small test withand it seems that this resource has the same problem as
google_storage_bucket
:Setting both properties to
computed: true
in alignment with the others fixed the problem on both resources. But please don't ask me why 😁@prauc FYI
Fixes #12804
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7923