Add retry for internal 160009 errors #14727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14691
This does a bit of refactoring- I did that to wrap my head around the existing logic, and hopefully make it more clear. Sorry for the extra noise!
I've confirmed our existing tests pass (
TestAccProjectService_
,TestAccProject_deleteDefaultNetwork
), but was unable to reproduce the error so far to confirm the fix works.Our logs show some escape characters in the sequence (the relevant bit is
"[service pubsub.googleapis.com encountered internal error: type: \"googleapis.com\" subject: \"160009\" ] with failed services [pubsub.googleapis.com]",
) so I looked for a few different parts of the string in the body rather than one long string- without a repro, I'm not 100% certain what the correct characters would be.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8017