Breaking change: Rework taint model in GKE #15959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7928, #13309
This applies roughly the same model we're using with labels, where we limit what we write back into state during reads based on what's already in state. This gives us the opportunity to drastically simplify the interactions of the field, while unfortunately trading away authoritative-ness. We could easily reintroduce an authoritative field by making
effective_taints
O+C though- one of the benefits ofeffective_X
output fields here and in the labels rework.Not having update support is awkward- we'd be able to pick up new keys to manage if so, and delete keys, but that'll only update
google_container_node_pool
when added due to other complications with GKE cluster.TestAccContainerNodePool_withSandboxConfig
gets drastically simpler with this change- it's boring now! There's an unmanaged taint being added in the background there, with thewithNodeConfig
tests already covering taints added at create time.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9011