Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GKE front matter, bad field docs #17330

Conversation

modular-magician
Copy link
Collaborator

Started as a PR to fix a bad field type as GoogleCloudPlatform/magic-modules#6780 introduced private_endpoint_subnetwork as an optional field but inserted it into the website as a read-only field, but when doing a minor touchup to the page's front matter I ended up reworking it pretty much entirely from

image

to

image

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#10018

* Fix GKE front matter, bad field docs

* Update container_cluster.html.markdown

[upstream:f25a214012dc398a6c1a07531a7ae85e049aa538]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 0b64b41 into hashicorp:main Feb 20, 2024
4 checks passed
SarahFrench pushed a commit that referenced this pull request Mar 1, 2024
* Fix GKE front matter, bad field docs

* Update container_cluster.html.markdown

[upstream:f25a214012dc398a6c1a07531a7ae85e049aa538]

Signed-off-by: Modular Magician <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant