Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated google_container_cluster #2996

Merged
merged 2 commits into from
May 15, 2019
Merged

Conversation

night-gold
Copy link
Contributor

Added precision on the valid subnet for 'master_ipv4_cidr_block' in 'private_cluster_config' block.

Added precision on the valid subnet for 'master_ipv4_cidr_block' in 'private_cluster_config' block.
@rileykarson
Copy link
Collaborator

Sorry for the delay on our end @night-gold- do you have a source for that value needing to be /28? It doesn't look like that's reflected on the GKE docs.

@night-gold
Copy link
Contributor Author

I tried it with terraform and it was in the error message.

In the deprecated way of doing it, that has been removed, it was already written that it should be a /28 CIDR for it to work.

@mrparkers
Copy link
Contributor

I can also confirm the /28 limitation for masters in private clusters. Here are the supporting docs: https://cloud.google.com/kubernetes-engine/docs/how-to/private-clusters#limitations

@inductor
Copy link

@rileykarson ping

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @night-gold! I'm going to push a commit to clean up the wording slightly, and then this will be good to go 👍

@ghost
Copy link

ghost commented Jun 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants