Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Beta operation waiting code and just wait at v1 instead. #319

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Remove Beta operation waiting code and just wait at v1 instead. #319

merged 1 commit into from
Aug 10, 2017

Conversation

rileykarson
Copy link
Collaborator

Followup to #310; let's just use the v1 API to wait on v0beta Operation objects too.

Smoke test:

TF_ACC=1 go test ./google -v -run=TestAccInstanceGroupManager_basic -timeout 120m
=== RUN   TestAccInstanceGroupManager_basic
--- PASS: TestAccInstanceGroupManager_basic (343.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	344.159s

@rileykarson rileykarson merged commit ff8bdc9 into hashicorp:master Aug 10, 2017
z1nkum pushed a commit to z1nkum/terraform-provider-google that referenced this pull request Aug 15, 2017
@rileykarson
Remove Beta operation waiting code and just wait at v1 instead. (hash…
7de59da 
…icorp#319)
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@rileykarson
Remove Beta operation waiting code and just wait at v1 instead. (hash…
13a40b3 
…icorp#319)
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @rileykarson
Add cloudbuild trigger to update guide (hashicorp#319)
3889c31
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rosbo rosbo rosbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rileykarson @rosbo