Don't attempt to delete default users on replica

[selmanj]

Fixes #347

[paddycarver]

Did this have any tests that failed before the change? If not, can we concoct a case that fails without the change?

[selmanj]

It did not. I was going to write a test but thought that the additional test might not be worth it since it's a failure situation that users shouldn't run into anymore (and each test has a cost, after all; in this case it's in the minutes).

However I think there's something to be said about someone who wants their own root@'%' user that's managed within terraform; if they end up adding replicas later, they'll end up hitting this same path. In that case it probably makes sense to have this failure scenario covered.

[selmanj]

I added a test ensuring we don't delete a root user found on the replica. It currently fails on master and passes on this branch.

The test itself is not great to read; would love input on how to make this more readable using the resource.TestCase/resource.TestStep structs.

[paddycarver]

LGTM!

[ryan-mf]

This was merged into master 12 days ago, but terraform-provider-google hasn't had a release since 1.3 on 8/17/2017:
https://github.com/terraform-providers/terraform-provider-google/releases

Now that Terraform is modular, we have to wait for the module to get its own release. Any idea when there will be a new release for terraform-provider-google?

[selmanj]

I agree @ryan-mf; we're focusing on that now (we are working on making our underlying test suite happy). Should be very soon...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!