Add support for Cloud Asset feeds #6821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added pre_create custom code hook * Adding the google_cloud_asset_project_feed resource type * Move the pre_create override further down. We need the provect var to be available by then. * Get the variables from the test environment * Just update the project variable, not the whole data structure. * Add the google_cloud_asset_folder_feed resource type * Adding the google_cloud_asset_organization_feed resource type * Remove blank lines to avoid unecessary diffs * Just noticed the attributes in the output destination were not marked as required. * Fix linter error * Update copyright * Add enum for contentType parameter * Moving folder and org id to params block * Removing unnecessary autogen_async flag * Moving the obj structure code to an encoder * Added folder_id computed attribute * Rename project to billing_project in folder and org feeds for consistency across resources and with gcloud command Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added resources for the Cloud Asset Inventory feeds. The feeds requires the billing project to be passed on via the
X-Goog-User-ProjectHTTP header. In order to accomplish this without modifying the current transport logic, I have added apre_createcustom code hook right before thesendRequestWithTimeoutfunction. It would be preferable to provide a proper option to do this without abusing theUserProjectOverridefield.This API is weird in the sense that the feed payload needs to be sent under a
feedattribute, but in the HTTP response the payload is directly in the body. I solved this by moving the feed under afeedattribute in thepre_commitandpre_updatehooks.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3750