Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bigtable version from 1.1.0 to 1.5.0 #6890

Merged

Conversation

ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Jul 30, 2020

Current Bigtable v1.1.0 doesn't support labels as attribute. So it is blocking
GoogleCloudPlatform/magic-modules#3793 which will fix #6813
as it throws errors when it try to add labels into Bigtable instance.

@ghost ghost added the size/xs label Jul 30, 2020
@ghost ghost requested review from rileykarson July 30, 2020 03:56
@rileykarson rileykarson merged commit 2e38a18 into hashicorp:master Jul 30, 2020
@rileykarson
Copy link
Collaborator

Whoops, fix #6813 was enough for GitHub to decide to close the linked issue. Reopening it.

@ryanyuan
Copy link
Contributor Author

thank you @rileykarson

dboshardy pushed a commit to dboshardy/terraform-provider-google that referenced this pull request Aug 3, 2020
* upstream/master:
  Add a random string to ad directory so tests can be run in parallel (hashicorp#3802) (hashicorp#6905)
  Set context early on in LoadAndValidate to prevent NPE (hashicorp#3800) (hashicorp#6903)
  Add tests for DICOM store pubsub topic removal. (hashicorp#3442) (hashicorp#6893)
  Bump Bigtable version from 1.1.0 to 1.5.0 (hashicorp#6890)
  Fix colon in doc notes (hashicorp#3796) (hashicorp#6888)
  Fix bug: diff being detected for source_repo_repository even when there are no changes (hashicorp#3786) (hashicorp#6886)
  Use proper prefix inside router_interface test (hashicorp#3795) (hashicorp#6883)
  Update Bigtable Num of Clusters Block Docs (hashicorp#3792) (hashicorp#6881)
@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support labels for Bigtable Instance
2 participants