Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default request timeout to 90s #7976

Conversation

modular-magician
Copy link
Collaborator

We sometimes see reports of requests timing out due to the 30 second limit on requests. This causes the retry transport to attempt to retry the request, assuming it failed. If the request did not fail and the API was just being slow to return, this can cause issues especially for resource creates.

Bumping this shouldn't have any negative effects other than slower failures in some cases, and 90 seconds should be long enough to avoid at least the issues we know about

This can be controlled by users with the request_timeout field in the provider block

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

all: bump default request timeout to avoid conflicts if creating a resource takes longer than expected

Derived from GoogleCloudPlatform/magic-modules#4303

@ghost ghost added the size/xs label Dec 10, 2020
@modular-magician modular-magician merged commit bbc230c into hashicorp:master Dec 10, 2020
@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant