Bump default request timeout to 90s #7976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes see reports of requests timing out due to the 30 second limit on requests. This causes the retry transport to attempt to retry the request, assuming it failed. If the request did not fail and the API was just being slow to return, this can cause issues especially for resource creates.
Bumping this shouldn't have any negative effects other than slower failures in some cases, and 90 seconds should be long enough to avoid at least the issues we know about
This can be controlled by users with the
request_timeout
field in the provider blockIf this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#4303