Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip guest accelerators if count is 0. #866

Merged
merged 5 commits into from
Jan 23, 2018
Merged

skip guest accelerators if count is 0. #866

merged 5 commits into from
Jan 23, 2018

Commits on Jan 22, 2018

  1. skip guest accelerators if count is 0. 

    Instances in instance groups in google will fail to provision, despite
requesting 0 GPUs. This came up for me when trying to provision
a similar instance group in all available regions, but only asking for
GPU's in those that support them by parameterizing the `count` and
setting it to 0.

This might be a violation of some terraform principles. For example,
testing locally with this change `terraform` did not recognize that
indeed my infra needed to be re-deployed (from it's pov, I assume it
believes this because inputs hadn't changed). Additionally, there may be
valid reasons for creating an instance template with 0 gpu's that can be
tuned upwards.
    @jacobstr
    jacobstr committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    8d3b014 View commit details
    Browse the repository at this point in the history

  2. Add guest accelerator skip test for instances.

    @jacobstr
    jacobstr committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    37ea402 View commit details
    Browse the repository at this point in the history

  3. do not leave empty pointers to guest accelerators.

    @jacobstr
    jacobstr committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    6c402ad View commit details
    Browse the repository at this point in the history

  4. attempt to clear guest accelerator diff

    @jacobstr
    jacobstr committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    47dffbc View commit details
    Browse the repository at this point in the history

  5. conditionally customize diff for guest accels

    @jacobstr
    jacobstr committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    3875034 View commit details
    Browse the repository at this point in the history